Repository navigation
Report the layout refusal first in described runs with several layouts - #246
Merged
Merged
Conversation
#245) The run lists R_HETEROGENEOUS_LAYOUT_NOT_ENABLED before the axis review's issues, and the arrangement issues no longer advise exporting the images the same way. The notebook's axis step says no roles are suggested because the units declare different layouts. The refusal codes are unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
…note Two fluorescence layouts with different channel lists were described as "fluorescence units, which are arranged differently". Say the channel lists differ. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3qp9AxjpGPw9xfWAUJNqc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #245
What changes
R_HETEROGENEOUS_LAYOUT_NOT_ENABLEDfirst, before the axis review's issues (run/description_run.py,heterogeneous_first).inconsistent_mapping,missing_axes,ambiguous_missing_axes) stay errors in a heterogeneous run, but their advice to export the images the same way is replaced by a note that they follow from the different layouts. Runs of one layout keep the old advice.Nothing refused before is accepted: the set of refusal codes of the issue's reproduction is asserted to be exactly
{R_HETEROGENEOUS_LAYOUT_NOT_ENABLED, inconsistent_mapping}, as before.The
missing_axesrule (gap from the #243 review)sum(len(a) == len(longest) ...) == 1inimage_consistency.arrangement_issuesis an equivalent mutant: two different arrangements of the longest length are never both subsequences of it, so theall(...)clause before it already excludes them. With>= 1the full suite (4933 tests) still passes, and no test can kill it. The new test instead pins the behaviour for every pair and triple of 8 arrangements against an independent statement of the rule. The redundant clause could be removed in a separate change.Tests
tests/test_heterogeneous_refusal_first.py(8 tests). Three fail on main (order, advice, axis step text).Generated by Claude Code